Repository navigation
chore(deps): pin punktfunk 12e4dfd1b - #69
Merged
Merged
Conversation
The rev is punktfunk main at 12e4dfd1b. It carries #2245, which holds a Fixed rate through the bring-up ramp and moves the stored-rate rule into core's `session_bitrate_kbps`. The page offers no PyroWave, so that rule returns the player's rate unchanged and the driver needs no change. The server follows the same rev.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the four punktfunk pins (
punktfunk-core,pf-console-ui,pf-client-core, and the server's core) fromdd871ad7eto12e4dfd1b, punktfunk main with #2245 (hold a Fixed PyroWave rate). Lockfiles moved for the git packages only.No driver change. #2245 puts the stored-rate rule in
punktfunk_core::quic::session_bitrate_kbps: a client that offered PyroWave as its preference gets Automatic when the host lands on another codec. The native pump applies it; the page does not need to.pf_session_codecsmasks the offer to H.264 / HEVC / AV1, soPREFERREDandCODECSnever carryCODEC_PYROWAVEand the rule returnsasked_kbpsunchanged. The host applies the same rule to the same Hello and reads the same number.Nothing zeroes a stored rate on the way to
pf_session_hello:settings.tsclamps a positive rate to 500..200000 and anything else to 0;app.tsstreamOptionssendsprefs.bitrateKbps;engine.tspassesopts.bitrateKbps ?? 0(an SDR or codec-fallback restart reuses the same options);pf_session_helloputs it inHello.bitrate_kbpsandAbr::newreads the same field. So a stored rate stays a Fixed H.26x rate, which the driver's newfixed_kbpspath watches and never moves.Checked on a Mac:
npm ci,npm run check,npm test(Node 24; 85 + 4 pass),cargo fmt --check,cargo clippy --all-targets,cargo clippy --target wasm32-unknown-emscripten,cargo testforpackages/streamandserver(--locked). Not run locally: the emsdk wasm link, Storybook, the screenshots, the image. CI covers those.